Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reprioritized FIXME comments #287

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: reprioritized FIXME comments #287

merged 2 commits into from
Jul 12, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

  • Aligning FIXME and TODO comments in code wrt priority of topic
  • Changed three FIXME comments to TODO as non-major issues were addressed
  • All major issues remain labeled as FIXME

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: Sonar Cloud Findings

How to Test

  • Test the code

n/a

What to Check

n/a

Other Information

See Sonar Cloud Reporting -> Code Smells for Main branch

@lechnerc77 lechnerc77 self-assigned this Jul 12, 2023
@lechnerc77 lechnerc77 added the ignore-for-release All things not to be mentioned in release notes label Jul 12, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 12, 2023
@lechnerc77 lechnerc77 requested a review from kuntzed July 12, 2023 12:37
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 12, 2023 12:38
@lechnerc77 lechnerc77 added the sonar cloud finding Finding from Sonar Cloud quality checks label Jul 12, 2023
@lechnerc77 lechnerc77 requested a review from kuntzed July 12, 2023 14:42
@lechnerc77 lechnerc77 disabled auto-merge July 12, 2023 14:42
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 12, 2023 14:42
@lechnerc77 lechnerc77 merged commit 00fed85 into main Jul 12, 2023
10 checks passed
@lechnerc77 lechnerc77 deleted the align-fixme-messages branch July 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuntzed kuntzed kuntzed approved these changes

Assignees

@lechnerc77 lechnerc77

Labels
ignore-for-release All things not to be mentioned in release notes sonar cloud finding Finding from Sonar Cloud quality checks
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.
2 participants
@lechnerc77 @kuntzed